Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtract_scalar kernel #1152

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Add subtract_scalar kernel #1152

merged 3 commits into from
Jan 12, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jan 11, 2022

Which issue does this PR close?

Closes #1153.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1152 (506e730) into master (719096b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
+ Coverage   82.55%   82.56%   +0.01%     
==========================================
  Files         169      169              
  Lines       50456    50512      +56     
==========================================
+ Hits        41655    41707      +52     
- Misses       8801     8805       +4     
Impacted Files Coverage Δ
arrow/src/compute/kernels/arithmetic.rs 84.64% <100.00%> (+0.50%) ⬆️
arrow/src/datatypes/field.rs 53.79% <0.00%> (-0.31%) ⬇️
arrow/src/array/transform/mod.rs 85.43% <0.00%> (-0.27%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (-0.23%) ⬇️
parquet/src/compression.rs 88.59% <0.00%> (ø)
parquet/src/arrow/arrow_writer.rs 98.07% <0.00%> (ø)
arrow/src/compute/kernels/comparison.rs 91.96% <0.00%> (ø)
arrow/src/array/array_string.rs 97.40% <0.00%> (+0.32%) ⬆️
arrow/src/util/test_util.rs 92.04% <0.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719096b...506e730. Read the comment docs.

+ Zero,
{
#[cfg(feature = "simd")]
return simd_subtract_scalar(&array, scalar);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rebase this to simd_unary_math_op once #1151 gets merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be good to go now

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@alamb alamb merged commit a800a88 into apache:master Jan 12, 2022
@viirya
Copy link
Member Author

viirya commented Jan 12, 2022

Thanks @alamb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support scalar mathematics kernels for Array and scalar value
4 participants