-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtract_scalar kernel #1152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
==========================================
+ Coverage 82.55% 82.56% +0.01%
==========================================
Files 169 169
Lines 50456 50512 +56
==========================================
+ Hits 41655 41707 +52
- Misses 8801 8805 +4
Continue to review full report at Codecov.
|
+ Zero, | ||
{ | ||
#[cfg(feature = "simd")] | ||
return simd_subtract_scalar(&array, scalar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will rebase this to simd_unary_math_op
once #1151 gets merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be good to go now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @viirya
Thanks @alamb ! |
Which issue does this PR close?
Closes #1153.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?