Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix record formatting in 1.58 #1178

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #1177

Rationale for this change

Fixes failing tests

What changes are included in this PR?

There appears to have been a change in the debug formatting of floats in 1.58 that causes the debug output to change - in particular it prints in scientific notation where previously it did not. I can't find explicit mention of this in the release notes, but have confirmed it locally.

I've replicated the behavior tested by the tests, but I'm not entirely sure this is exactly what it would have previously output for all cases. The debug outputs are not stable.

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1178 (2069358) into master (231cf78) will increase coverage by 0.07%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1178      +/-   ##
==========================================
+ Coverage   82.59%   82.66%   +0.07%     
==========================================
  Files         173      173              
  Lines       50919    50902      -17     
==========================================
+ Hits        42055    42077      +22     
+ Misses       8864     8825      -39     
Impacted Files Coverage Δ
arrow/src/buffer/immutable.rs 98.92% <ø> (ø)
parquet/src/schema/printer.rs 72.47% <50.00%> (ø)
arrow/src/compute/kernels/arithmetic.rs 90.86% <73.33%> (+5.29%) ⬆️
arrow/src/util/test_util.rs 92.04% <100.00%> (ø)
parquet/src/arrow/levels.rs 84.28% <100.00%> (+1.40%) ⬆️
parquet/src/record/api.rs 91.65% <100.00%> (+0.04%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/builder.rs 86.62% <0.00%> (+0.11%) ⬆️
arrow/src/array/transform/mod.rs 85.56% <0.00%> (+0.13%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d7a21...2069358. Read the comment docs.

@alamb alamb merged commit 66b84f3 into apache:master Jan 15, 2022
@alamb
Copy link
Contributor

alamb commented Jan 15, 2022

Thanks @tustvold

ovr pushed a commit to cube-js/arrow-rs that referenced this pull request Apr 2, 2024
ovr pushed a commit to cube-js/arrow-rs that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parquet Record Tests Fail on Rust 1.58
4 participants