Truncate bitmask on BooleanBufferBuilder::resize: #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
tustvold
commented
Jan 15, 2022
|
|
||
| #[test] | ||
| fn test_split_off() { | ||
| let t = Type::primitive_type_builder("col", PhysicalType::INT32) |
There was a problem hiding this comment.
I could not find a more ergonomic way to construct this type
tustvold
force-pushed
the
truncate-bitmask-split
branch
from
94b5a1f
to
bc506a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1183 +/- ##
==========================================
+ Coverage 82.66% 82.67% +0.01%
==========================================
Files 173 173
Lines 50902 50929 +27
==========================================
+ Hits 42077 42105 +28
+ Misses 8825 8824 -1
Continue to review full report at Codecov.
|
jhorstmann
reviewed
Jan 16, 2022
arrow/src/array/builder.rs
Outdated
| #[inline] | ||
| pub fn resize(&mut self, len: usize) { | ||
| let len_bytes = bit_util::ceil(len, 8); | ||
| self.buffer.resize(len_bytes, 0) |
There was a problem hiding this comment.
Should this also set self.len?
There was a problem hiding this comment.
Oh yes 🤦
Will fix and add a test
alamb
approved these changes
Jan 17, 2022
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #1037 .
Rationale for this change
When splitting a null bitmask off, the code added in #1054 would return the entire bitmask that was read. This isn't a problem as
ArrayDatadoesn't care about trailing data in buffers, in fact it is critical for packed bitmasks and array data slices to work, but it can be a tad surprising.What changes are included in this PR?
Modifies
DefinitionLevelBuffer::split_bitmaskto truncate the returnedBitmapfor the avoidance of confusion. Also uses a more efficientappend_packed_rangeto construct the remainder buffer.Are there any user-facing changes?
Adds a
BooleanBufferBuilder::resizemethod