Add from_iter_values for binary array
#1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
- Coverage 82.64% 82.64% -0.01%
==========================================
Files 173 173
Lines 50865 50874 +9
==========================================
+ Hits 42037 42044 +7
- Misses 8828 8830 +2
Continue to review full report at Codecov.
|
alamb
approved these changes
Jan 17, 2022
| } | ||
|
|
||
| // iterator size hint may not be correct so compute the actual number of offsets | ||
| assert!(!offsets.is_empty()); // wrote at least one |
alamb
added
the
enhancement
alamb
changed the title
from_iter_values for binary array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
note the implementation is mirrored from string array
Are there any user-facing changes?
added API for generic binary array