Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in display of Float16Array #1194

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

helgikrs
Copy link
Contributor

Which issue does this PR close?

Closes #1193 .

What changes are included in this PR?

Due to a typo the float16 array was being cast to a float32 array,
causing a crash when pretty printing a record batch containing float16.
Fixed that typo and added a test.

Are there any user-facing changes?

No.

Due to a typo the float16 array was being cast to a float32 array,
causing a crash when pretty printing a record batch containing float16.
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1194 (d53b3e0) into master (713bd6d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head d53b3e0 differs from pull request most recent head e0c4172. Consider uploading reports for the commit e0c4172 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1194   +/-   ##
=======================================
  Coverage   82.70%   82.70%           
=======================================
  Files         173      173           
  Lines       51055    51055           
=======================================
  Hits        42225    42225           
  Misses       8830     8830           
Impacted Files Coverage Δ
arrow/src/util/display.rs 19.62% <0.00%> (ø)
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 85.43% <0.00%> (-0.14%) ⬇️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713bd6d...e0c4172. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Jan 18, 2022

Thanks @helgikrs

@alamb alamb changed the title bugfix in display of float16 array Fix in display of Float16Array Jan 18, 2022
@alamb alamb merged commit 9d637a4 into apache:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty print a RecordBatch containing Float16 triggers a panic
4 participants