Add comparison support for fully qualified BinaryArray #1195
Conversation
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
delete dyn comparison which will be added in successive PRs Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.01%
==========================================
Files 175 175
Lines 51561 51660 +99
==========================================
+ Hits 42629 42719 +90
- Misses 8932 8941 +9
Continue to review full report at Codecov.
|
|
Hi teams, I find one of my failures is due to the reference mistake, which I will fix it. But others are caused by |
|
Hi @HaoYang670 and @gangliao - sorry for the CI failures. I believe they will be fixed one #1199 is merged |
Signed-off-by: remzi <13716567376yh@gmail.com>
| assert_eq!(v, expected[i]); | ||
| } | ||
|
|
||
| let left = LargeBinaryArray::from_vec($left); |
| } | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
It might be worth testing with some non-UTF-8 values, i.e. &[u8], just mix in some stuff in the range b < 128 || b >= 192 which indicate UTF-8 continuation characters.
There was a problem hiding this comment.
Thank you for your advice @tustvold. I'd like to do a follow-on PR which I will add non-utf8 tests and also add dynamic dispatched comparisons.
| } | ||
|
|
||
| #[test] | ||
| fn test_binary_eq_scalar_on_slice() { |
|
Thank you @HaoYang670 -- this looks great. @tustvold has a good suggestion regarding testing, but we can either do that as part of this PR or as a follow on. |
|
Thanks again @HaoYang670 ! |
Which issue does this PR close?
None. This PR is the first part of #1108.
Rationale for this change
What changes are included in this PR?
We add native comparison support for fully qualified BinaryArray. Support for dynamic BinaryArray will be added in next PR
Are there any user-facing changes?