Use new DecimalArray creation API in arrow crate #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
alamb
force-pushed
the
alamb/clean_up_decimal_creation2
branch
from
fc8ae0b
to
f64a3ea
Compare
alamb
commented
Jan 30, 2022
| t | ||
| }) | ||
| .collect::<Result<DecimalArray>>()? | ||
| // PERF: we could avoid re-validating that the data in |
There was a problem hiding this comment.
this re-validation occurs in DecimalBuilder as well, so this change isn't worse. I just noticed it while working on the code and figured I would leave a hint for future readers
Codecov Report
@@ Coverage Diff @@
## master #1249 +/- ##
==========================================
- Coverage 83.04% 83.03% -0.02%
==========================================
Files 180 180
Lines 52424 52365 -59
==========================================
- Hits 43537 43479 -58
+ Misses 8887 8886 -1
Continue to review full report at Codecov.
|
alamb
force-pushed
the
alamb/clean_up_decimal_creation2
branch
from
f64a3ea
to
11f1832
Compare
|
FYI @liukun4515 |
I will review this later in this weekend. |
liukun4515
approved these changes
Feb 15, 2022
|
Thanks @liukun4515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1223 so draft until that is doneRationale:
#1223 introduces a more performant and idiomatic API for creating
DecimalArrays thanDecimalBuilderso update the code to use that.