Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delimiter from csv Writer #1342

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Remove delimiter from csv Writer #1342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions arrow/src/csv/writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ where
pub struct Writer<W: Write> {
/// The object to write to
writer: csv_crate::Writer<W>,
/// Column delimiter. Defaults to `b','`
#[allow(dead_code)]
delimiter: u8,
/// Whether file should be written with headers. Defaults to `true`
has_headers: bool,
/// The date format for date arrays
Expand All @@ -124,7 +121,6 @@ impl<W: Write> Writer<W> {
let writer = builder.delimiter(delimiter).from_writer(writer);
Writer {
writer,
delimiter,
has_headers: true,
date_format: DEFAULT_DATE_FORMAT.to_string(),
datetime_format: DEFAULT_TIMESTAMP_FORMAT.to_string(),
Expand Down Expand Up @@ -475,7 +471,6 @@ impl WriterBuilder {
let writer = builder.delimiter(delimiter).from_writer(writer);
Writer {
writer,
delimiter,
has_headers: self.has_headers,
date_format: self
.date_format
Expand Down