Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor StructArray::from #1360

Merged
merged 3 commits into from Feb 24, 2022

Conversation

HaoYang670
Copy link
Contributor

Which issue does this PR close?

Closes #1351.

Rationale for this change

Rewrite StructArray::from to avoid periodical memory reallocation.

What changes are included in this PR?

Are there any user-facing changes?

No

Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1360 (d707a45) into master (89ee9ac) will decrease coverage by 0.00%.
The diff coverage is 65.21%.

❗ Current head d707a45 differs from pull request most recent head 7391a8a. Consider uploading reports for the commit 7391a8a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   83.03%   83.03%   -0.01%     
==========================================
  Files         181      181              
  Lines       52936    52945       +9     
==========================================
+ Hits        43955    43961       +6     
- Misses       8981     8984       +3     
Impacted Files Coverage Δ
arrow/src/csv/writer.rs 71.32% <0.00%> (-0.82%) ⬇️
parquet/src/file/metadata.rs 93.88% <ø> (+0.43%) ⬆️
parquet/src/file/serialized_reader.rs 94.60% <ø> (-0.04%) ⬇️
arrow/src/json/writer.rs 91.77% <72.22%> (-0.70%) ⬇️
arrow/src/array/array_struct.rs 89.24% <100.00%> (-0.05%) ⬇️
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (ø)
arrow/src/array/transform/mod.rs 84.65% <0.00%> (+0.26%) ⬆️
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ee9ac...7391a8a. Read the comment docs.

@nevi-me nevi-me merged commit 57545b0 into apache:master Feb 24, 2022
@HaoYang670 HaoYang670 deleted the issue1351_refactor_structarray_from branch February 24, 2022 09:10
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor StructArray::from
4 participants