Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy lints #1363

Merged
merged 4 commits into from Feb 25, 2022
Merged

Conversation

HaoYang670
Copy link
Contributor

Which issue does this PR close?

Closes #1362 .

Rationale for this change

Rust is updated to 1.59.0. Some new lints are added to cargo clippy.

What changes are included in this PR?

run

cargo clippy --features test_common --features prettyprint --features=async --all-targets --workspace -- -D warnings

and fix all errors and warnings

Are there any user-facing changes?

No

Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Feb 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1363 (c7bb81a) into master (a2e629d) will decrease coverage by 0.04%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
- Coverage   83.03%   82.98%   -0.05%     
==========================================
  Files         181      181              
  Lines       52956    52932      -24     
==========================================
- Hits        43972    43926      -46     
- Misses       8984     9006      +22     
Impacted Files Coverage Δ
arrow/src/array/array_dictionary.rs 91.12% <0.00%> (-0.47%) ⬇️
parquet/src/arrow/array_reader.rs 78.27% <0.00%> (ø)
parquet/src/arrow/levels.rs 84.67% <ø> (ø)
arrow/src/compute/kernels/comparison.rs 92.18% <100.00%> (ø)
arrow/src/compute/kernels/take.rs 95.27% <100.00%> (ø)
arrow/src/datatypes/field.rs 54.10% <100.00%> (ø)
arrow/src/datatypes/schema.rs 73.45% <100.00%> (ø)
arrow/src/ipc/convert.rs 95.61% <100.00%> (+0.39%) ⬆️
arrow/src/json/reader.rs 83.54% <100.00%> (+0.14%) ⬆️
arrow/src/record_batch.rs 91.97% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e629d...c7bb81a. Read the comment docs.

@jimexist jimexist merged commit 08a7160 into apache:master Feb 25, 2022
@HaoYang670 HaoYang670 deleted the issue1362_fix_clippy_warning branch February 25, 2022 12:19
@alamb
Copy link
Contributor

alamb commented Feb 28, 2022

Thank you @HaoYang670 and @jimexist 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo clippy fails on the master branch
4 participants