Replace filter_row_groups with ReadOptions in parquet SerializedFileReader
#1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
commented
Mar 3, 2022
This was referenced Mar 3, 2022
yjshen
changed the title
ReadOptions with builder API, filter row groups that satisfy all filters, and enable filter row groups by range.
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
==========================================
+ Coverage 83.03% 83.12% +0.09%
==========================================
Files 181 181
Lines 52936 53329 +393
==========================================
+ Hits 43955 44332 +377
- Misses 8981 8997 +16
Continue to review full report at Codecov.
|
|
Integration test failure seems unrelated. |
sunchao
approved these changes
Mar 5, 2022
| self | ||
| } | ||
|
|
||
| /// Add a range predicate on filtering row groups if their midpoints are within the range |
There was a problem hiding this comment.
nit: maybe indicate whether the start and end is inclusive or exclusive
There was a problem hiding this comment.
Thanks, this is important. I've updated the doc.
| /// Get midpoint offset for a row group | ||
| fn get_midpoint_offset(meta: &RowGroupMetaData) -> i64 { | ||
| let col = meta.column(0); | ||
| let mut offset = col.data_page_offset(); |
There was a problem hiding this comment.
For encrypted Parquet files we'll need to use file_offset but it's fine for now since it's not supported anyways.
alamb
changed the title
ReadOptions with builder API, filter row groups that satisfy all filters, and enable filter row groups by range.ReadOptions with builder API, for parquet filter row groups that satisfy all filters, and enable filter row groups by range.
|
Thanks @yjshen |
alamb
changed the title
ReadOptions with builder API, for parquet filter row groups that satisfy all filters, and enable filter row groups by range.filter_row_groups with ReadOptions in parquet SerializedFileReader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #158.
Rationale for this change
To support parallel parquet reading at row group level.
What changes are included in this PR?
One extra parameter while filtering row groups using row group metadata.
The midpoint and range comparison are from parquet-mr
ParquetInputSplitsemantic by selecting belonged row groups.Are there any user-facing changes?
Yes.