Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration testing docs #1403

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 5, 2022

Which issue does this PR close?

Re #1398

Rationale for this change

It took me a while to sort out how to run the integration test so I figured I would encode some of that knowledge in docs to assist myself (or others) in the future

What changes are included in this PR?

Update developer docs

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Mar 5, 2022
@github-actions github-actions bot added the arrow-flight Changes to the arrow-flight crate label Mar 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #1403 (73ea01a) into master (2bca71e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   83.12%   83.13%           
=======================================
  Files         181      181           
  Lines       53329    53329           
=======================================
+ Hits        44328    44333    +5     
+ Misses       9001     8996    -5     
Impacted Files Coverage Δ
...-testing/src/bin/flight-test-integration-client.rs 0.00% <ø> (ø)
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
arrow/src/array/transform/mod.rs 86.43% <0.00%> (+0.22%) ⬆️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bca71e...73ea01a. Read the comment docs.

@liukun4515
Copy link
Contributor

Thanks for the guidance, and we can run the IT test easier.

@@ -43,7 +43,3 @@ tonic-build = "0.6"
# Pin specific version of the tonic-build dependencies to avoid auto-generated
# (and checked in) arrow.flight.protocol.rs from changing
proc-macro2 = ">1.0.30"

#[lib]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driveby cleanup

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will be very useful

@sunchao sunchao merged commit 1fbe618 into apache:master Mar 6, 2022
@alamb alamb deleted the alamb/integration_test_docs branch March 7, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants