Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate bound check in the function shift #1409

Merged

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

Closes #1408.

Rationale for this change

Replace clamp(-offset, 0, value_len) by clamp_min(-offset, 0). Because we have compared offset and value_len before.

Are there any user-facing changes?

No

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1409 (42858fc) into master (f19d1ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1409   +/-   ##
=======================================
  Coverage   83.16%   83.16%           
=======================================
  Files         182      182           
  Lines       53394    53394           
=======================================
+ Hits        44405    44406    +1     
+ Misses       8989     8988    -1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/window.rs 100.00% <100.00%> (ø)
arrow/src/datatypes/field.rs 53.79% <0.00%> (-0.31%) ⬇️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
parquet_derive/src/parquet_field.rs 66.43% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19d1ed...42858fc. Read the comment docs.

@sunchao sunchao merged commit fcb8950 into apache:master Mar 11, 2022
@sunchao
Copy link
Member

sunchao commented Mar 11, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate bound check in function shift
5 participants