Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust version 1.59 #1411

Closed
wants to merge 1 commit into from
Closed

Update rust version 1.59 #1411

wants to merge 1 commit into from

Conversation

jackwener
Copy link
Member

Which issue does this PR close?

Closes #1377

Rationale for this change

None

What changes are included in this PR?

update the rust version

Are there any user-facing changes?

None

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Mar 9, 2022
@jackwener jackwener changed the title Update rust version Update rust version 1.59 Mar 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1411 (25b4455) into master (ab41c25) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
+ Coverage   83.10%   83.16%   +0.06%     
==========================================
  Files         181      182       +1     
  Lines       53244    53394     +150     
==========================================
+ Hits        44247    44406     +159     
+ Misses       8997     8988       -9     
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 86.31% <0.00%> (-0.12%) ⬇️
arrow/src/array/ffi.rs 100.00% <0.00%> (ø)
arrow/src/util/reader_parser.rs 65.21% <0.00%> (ø)
arrow/src/array/array_binary.rs 93.28% <0.00%> (+0.05%) ⬆️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️
arrow/src/array/equal/mod.rs 93.24% <0.00%> (+0.33%) ⬆️
parquet/src/file/serialized_reader.rs 95.65% <0.00%> (+1.04%) ⬆️
arrow/src/ffi.rs 85.78% <0.00%> (+1.16%) ⬆️
arrow/src/csv/reader.rs 89.89% <0.00%> (+1.56%) ⬆️
arrow/src/datatypes/ffi.rs 73.65% <0.00%> (+2.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab41c25...25b4455. Read the comment docs.

@Dandandan
Copy link
Contributor

Why would this need updating? It is the minimum supported version of rust.
See:
https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field

@jackwener
Copy link
Member Author

Why would this need updating? It is the minimum supported version of rust. See: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field

Thanks for your reply.❤

@jackwener jackwener closed this Mar 9, 2022
@jackwener
Copy link
Member Author

We can close this related issue

@jackwener jackwener deleted the rust branch March 9, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rust-version to 1.59
3 participants