Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UnionArray infilter kernel #1412

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented Mar 9, 2022

Which issue does this PR close?

Closes #1394.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 9, 2022
@viirya
Copy link
Member Author

viirya commented Mar 9, 2022

cc @alamb

@codecov-commenter
Copy link

Codecov Report

Merging #1412 (6caca96) into master (1fbe618) will increase coverage by 0.05%.
The diff coverage is 87.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
+ Coverage   83.13%   83.18%   +0.05%     
==========================================
  Files         182      183       +1     
  Lines       53321    53613     +292     
==========================================
+ Hits        44330    44600     +270     
- Misses       8991     9013      +22     
Impacted Files Coverage Δ
arrow/src/array/data.rs 82.95% <54.54%> (-0.21%) ⬇️
arrow/src/array/transform/union.rs 75.00% <75.00%> (ø)
arrow/src/array/transform/mod.rs 86.29% <84.61%> (-0.03%) ⬇️
arrow/src/compute/kernels/filter.rs 87.22% <100.00%> (+1.82%) ⬆️
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️
arrow/src/array/ffi.rs 100.00% <0.00%> (ø)
arrow-flight/src/utils.rs 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbe618...6caca96. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Mar 14, 2022

Sorry I have been a bit backed up for arrow reviews. Checking this one out now

@viirya
Copy link
Member Author

viirya commented Mar 15, 2022

Thank you @alamb !

@alamb alamb changed the title filter kernel should work with UnionArray Add support for UnionArray infilter kernel Mar 16, 2022
@alamb alamb merged commit bfccb5f into apache:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter kernel should work with UnionArrays
3 participants