remove redundant if/clamp_min/abs #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jameslamb @jimexist PTAL❤ It's a small change, remove some redundant function-call |
|
I think it is a good refactor. |
alamb
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Looks fine to me. I suspect this doesn't make any practical difference as the overhead of actually calling concat will dominate any control flow or arithmetic overhead, but one might also argue that this logic is clearer
thank you @jackwener
|
Yes, It don't have big performance impact because key performance overhead is in |
|
Thanks again @jackwener |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1427.
Rationale for this change
None
What changes are included in this PR?
There are some redundant code for control flow
ifis control flow will break the cpu pipeline, we should reduce the uselessif.bbs()should remove, and replace with code in the ifclamp_minis uselessAre there any user-facing changes?
None