Support nullable keys in DictionaryArray::try_new #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunchao
approved these changes
Mar 11, 2022
arrow/src/array/array_dictionary.rs
Outdated
| Ok(data.into()) | ||
| match keys.data().null_buffer() { | ||
| Some(buffer) if keys.data().null_count() > 0 => { | ||
| data = data.null_bit_buffer(buffer.clone()); |
There was a problem hiding this comment.
nit: we can update the null count here too, instead of calculating it later in build.
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 185 185
Lines 53764 53778 +14
=======================================
+ Hits 44449 44463 +14
Misses 9315 9315
Continue to review full report at Codecov.
|
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1429.