Fix generate_interval_case in integration test #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some test failures. I will take look. |
Codecov Report
@@ Coverage Diff @@
## master #1446 +/- ##
==========================================
- Coverage 82.67% 82.65% -0.03%
==========================================
Files 185 185
Lines 53866 53898 +32
==========================================
+ Hits 44535 44549 +14
- Misses 9331 9349 +18
Continue to review full report at Codecov.
|
alamb
approved these changes
Mar 17, 2022
| @@ -228,6 +228,20 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool { | |||
| IntervalUnit::DayTime => true, | |||
| IntervalUnit::MonthDayNano => false, // Native type is i128 | |||
| } | |||
| }, | |||
| (Int32, Interval(to_type)) => { | |||
There was a problem hiding this comment.
I double checked the format at this looks right to me
|
Thank you @alamb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1445.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?