Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite doc example of ListArray and LargeListArray #1447

Merged
merged 1 commit into from Mar 16, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

Closes #1433.

Rationale for this change

Make the example more readable.

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1447 (5d2563f) into master (729934c) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head 5d2563f differs from pull request most recent head ed98642. Consider uploading reports for the commit ed98642 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   82.67%   82.67%   -0.01%     
==========================================
  Files         185      185              
  Lines       53822    53866      +44     
==========================================
+ Hits        44500    44535      +35     
- Misses       9322     9331       +9     
Impacted Files Coverage Δ
arrow/src/array/array_list.rs 95.52% <ø> (ø)
integration-testing/src/lib.rs 0.00% <0.00%> (ø)
parquet/src/encodings/encoding.rs 93.56% <83.33%> (-0.16%) ⬇️
parquet/src/encodings/decoding.rs 89.54% <91.17%> (+0.07%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (ø)
arrow/src/array/transform/mod.rs 86.43% <0.00%> (+0.11%) ⬆️
parquet/src/util/bit_util.rs 93.19% <0.00%> (+0.18%) ⬆️
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729934c...ed98642. Read the comment docs.

@HaoYang670
Copy link
Contributor Author

@sunchao @jackwener Could you please help to review? Thank you!

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaoYang670
It improves readability

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@sunchao sunchao merged commit f0646f8 into apache:master Mar 16, 2022
@sunchao
Copy link
Member

sunchao commented Mar 16, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the doc examples of ListArray and LargeListArray more readable
5 participants