Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length kernel support for List Array #1488

Merged
merged 4 commits into from
Mar 28, 2022

Conversation

HaoYang670
Copy link
Contributor

Which issue does this PR close?

Closes #1470 .

What changes are included in this PR?

  1. add length kernel support for list array
  2. do some clean up work, including: rename private functions (make names more consistent), format the generic type bounds and update the doc.

Are there any user-facing changes?

Doc of the public function length is updated.

code format

Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1488 (aa6a138) into master (2932da3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
+ Coverage   82.71%   82.73%   +0.02%     
==========================================
  Files         187      188       +1     
  Lines       54255    54319      +64     
==========================================
+ Hits        44877    44941      +64     
  Misses       9378     9378              
Impacted Files Coverage Δ
arrow/src/compute/kernels/length.rs 100.00% <100.00%> (ø)
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
parquet/src/encodings/encoding.rs 93.37% <0.00%> (-0.19%) ⬇️
parquet/src/arrow/array_reader/builder.rs 66.30% <0.00%> (ø)
parquet/src/arrow/arrow_writer.rs 97.65% <0.00%> (+0.09%) ⬆️
parquet/src/arrow/levels.rs 84.80% <0.00%> (+0.12%) ⬆️
parquet/src/arrow/array_reader.rs 84.36% <0.00%> (+5.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2932da3...aa6a138. Read the comment docs.

Comment on lines 131 to 132
/// * length of null is null.
/// * length is in number of bytes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// * length of null is null.
/// * length is in number of bytes
/// * length of null is null.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Signed-off-by: remzi <13716567376yh@gmail.com>
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HaoYang670 and @viirya

@alamb alamb merged commit f1eba3c into apache:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add length kernel support for ListArray
4 participants