Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround nightly miri error in try_from_trusted_len_iter #1497

Merged

Conversation

jhorstmann
Copy link
Contributor

Which issue does this PR close?

Closes #1496.

Rationale for this change

I can't really explain why miri complained about this code, but the Result here is the only difference to several other usages of to_byte_slice. Extracting the result handling to a separate line seems to fix the issue.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1497 (ebb23d0) into master (c5442cf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ebb23d0 differs from pull request most recent head 161a8eb. Consider uploading reports for the commit 161a8eb to get more accurate results

@@            Coverage Diff             @@
##           master    #1497      +/-   ##
==========================================
- Coverage   82.68%   82.68%   -0.01%     
==========================================
  Files         188      188              
  Lines       54361    54362       +1     
==========================================
- Hits        44951    44947       -4     
- Misses       9410     9415       +5     
Impacted Files Coverage Δ
arrow/src/buffer/mutable.rs 90.53% <100.00%> (+0.02%) ⬆️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.46%) ⬇️
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
arrow/src/array/transform/mod.rs 86.35% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5442cf...161a8eb. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it makes MIRI happy it makes me happy 😆

@alamb alamb changed the title Fix miri error in try_from_trusted_len_iter Workaround nightly miri error in try_from_trusted_len_iter Mar 29, 2022
@alamb alamb merged commit 4022c11 into apache:master Mar 29, 2022
@alamb
Copy link
Contributor

alamb commented Mar 29, 2022

Thanks @jhorstmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIRI error in math_checked_divide_op/try_from_trusted_len_iter
3 participants