Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs that SlicesIterator ignores null values #1504

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Clarify docs that SlicesIterator ignores null values #1504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
187fbfa
Clarify docs that SlicesIterator ignores null values
alamb Mar 29, 2022
776d03c
Update arrow/src/compute/kernels/filter.rs
alamb Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions arrow/src/compute/kernels/filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,16 @@ macro_rules! downcast_dict_filter {
}};
}

/// An iterator of `(usize, usize)` each representing an interval `[start, end]` whose
/// slots of a [BooleanArray] are true. Each interval corresponds to a contiguous region of memory
/// to be "taken" from an array to be filtered.
/// An iterator of `(usize, usize)` each representing an interval
/// `[start, end)` whose slots of a [BooleanArray] are true. Each
/// interval corresponds to a contiguous region of memory to be
/// "taken" from an array to be filtered.
///
/// This is only performant for filters that copy across long contiguous runs
/// ## Notes:
///
/// 1. Ignores the validity bitmap (ignores nulls)
///
/// 2. Only performant for filters that copy across long contiguous runs
#[derive(Debug)]
pub struct SlicesIterator<'a> {
iter: UnalignedBitChunkIterator<'a>,
Expand Down