Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose documentation of GenericListBuilder #1525

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

comath
Copy link
Contributor

@comath comath commented Apr 5, 2022

Which issue does this PR close?

Closes #1518

What changes are included in this PR?

Imports the GenericListBuilder struct into the public facing array module so that it's automatically documented.

Are there any user-facing changes?

This exposes documentation, but does nothing else.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 5, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @comath !

@alamb alamb merged commit b9c4b39 into apache:master Apr 6, 2022
@alamb
Copy link
Contributor

alamb commented Apr 6, 2022

Thanks again @comath

@HaoYang670
Copy link
Contributor

Maybe we can also expose GenericListBuilder

@alamb alamb added the documentation Improvements or additions to documentation label Apr 15, 2022
@alamb alamb changed the title Fix for missing documentation of GenericListBuilder Expose documentation of GenericListBuilder Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for GenericListBuilder is not exposed.
3 participants