New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reading dictionaries from nested structs in ipc StreamReader
#1550
Fix reading dictionaries from nested structs in ipc StreamReader
#1550
Conversation
Thank you @dispanser ! @viirya I wonder if you might have a chance to review this PR? |
Thanks @dispanser @alamb. Yeah, I will review this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the fix is correct as we do this to fill dictionaries_by_field
.
for (i, field) in schema.all_fields().iter().enumerate() {
dictionaries_by_field[i] = ...
}
Actually, in FileReader
, it does the same:
let mut dictionaries_by_field = vec![None; schema.all_fields().len()];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, only one minor comment.
Codecov Report
@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 82.82% 82.84% +0.01%
==========================================
Files 190 190
Lines 54941 54966 +25
==========================================
+ Hits 45507 45535 +28
+ Misses 9434 9431 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you @dispanser
Which issue does this PR close?
Closes #1549.
Rationale for this change
Fixing a bug in the ipc stream reader, aligning with the
FileReader
implementation.What changes are included in this PR?
The actual bugfix is 4 characters, but this PR also includes a test to reproduce the bug.
Are there any user-facing changes?
No documetation changes needed.