Support FixedSizeBinary and FixedSizeList for the C data interface #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Apr 13, 2022
| """ | ||
| Python -> Rust -> Python | ||
| """ | ||
| a = pa.array(["a", None, "bb", "ccc"], pa.binary()) |
There was a problem hiding this comment.
This is just binary since pa.binary() doesn't have length specified (different from pa.binary(3) for instance).
There was a problem hiding this comment.
Yea. I found there is no test coverage for binary type yet so just added it.
|
cc @alamb @jorgecarleitao too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1553.
Rationale for this change
Currently the C data interface doesn't support
FixedSizeBinaryandFixedSizeListyet with the following error message:What changes are included in this PR?
This PR adds support for
FixedSizeBinaryandFixedSizeListin the Rust C data interface.Are there any user-facing changes?
Yes now
FixedSizeBinaryandFixedSizeListare supported. No API breakage.