Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/Write nested dictionaries under FixedSizeList in IPC #1610

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Apr 23, 2022

Which issue does this PR close?

Closes #1609.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1610 (1706cf8) into master (fd9cb23) will increase coverage by 0.00%.
The diff coverage is 88.00%.

❗ Current head 1706cf8 differs from pull request most recent head f645b64. Consider uploading reports for the commit f645b64 to get more accurate results

@@           Coverage Diff           @@
##           master    #1610   +/-   ##
=======================================
  Coverage   82.95%   82.96%           
=======================================
  Files         193      193           
  Lines       55435    55460   +25     
=======================================
+ Hits        45988    46010   +22     
- Misses       9447     9450    +3     
Impacted Files Coverage Δ
arrow/src/ipc/writer.rs 80.27% <62.50%> (-0.25%) ⬇️
arrow/src/ipc/reader.rs 89.43% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9cb23...f645b64. Read the comment docs.

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nevi-me nevi-me merged commit cbd0303 into apache:master Apr 25, 2022
@viirya
Copy link
Member Author

viirya commented Apr 25, 2022

Thank you @nevi-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read/write nested dictionary under fixed size list in ipc stream reader/write
3 participants