Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: simplify the function GenericListArray::get_type #1650

Merged
merged 2 commits into from
May 5, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

None.

Rationale for this change

Just to make the code more readable.

What changes are included in this PR?

Replace if-else branches by pattern matching.

Are there any user-facing changes?

No.

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label May 5, 2022
Signed-off-by: remzi <13716567376yh@gmail.com>
@HaoYang670 HaoYang670 changed the title Minor: simplify the code of ListArray::get_type Minor: simplify the function ListArray::get_type May 5, 2022
@HaoYang670 HaoYang670 changed the title Minor: simplify the function ListArray::get_type Minor: simplify the function GenericListArray::get_type May 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1650 (31fd858) into master (e51de5e) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
- Coverage   83.08%   83.08%   -0.01%     
==========================================
  Files         193      193              
  Lines       55778    55775       -3     
==========================================
- Hits        46343    46338       -5     
- Misses       9435     9437       +2     
Impacted Files Coverage Δ
arrow/src/array/array_list.rs 95.79% <66.66%> (+0.17%) ⬆️
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
parquet/src/encodings/encoding.rs 93.37% <0.00%> (-0.19%) ⬇️
arrow/src/array/transform/mod.rs 86.57% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51de5e...31fd858. Read the comment docs.

@tustvold tustvold merged commit 884de44 into apache:master May 5, 2022
@HaoYang670 HaoYang670 deleted the rewrite_list_get_type branch May 6, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants