Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DecimalType support in new_null_array #1659

Merged
merged 2 commits into from
May 6, 2022
Merged

Conversation

yjshen
Copy link
Member

@yjshen yjshen commented May 6, 2022

Which issue does this PR close?

N/A.

Rationale for this change

Support creation of all null decimal array.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels May 6, 2022
@yjshen yjshen removed the arrow-flight Changes to the arrow-flight crate label May 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1659 (194ea02) into master (884de44) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1659      +/-   ##
==========================================
- Coverage   83.08%   83.06%   -0.03%     
==========================================
  Files         193      193              
  Lines       55775    55788      +13     
==========================================
- Hits        46341    46340       -1     
- Misses       9434     9448      +14     
Impacted Files Coverage Δ
arrow/src/array/array.rs 89.67% <0.00%> (-3.04%) ⬇️
parquet/src/encodings/encoding.rs 93.37% <0.00%> (-0.19%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884de44...194ea02. Read the comment docs.

@alamb alamb changed the title minor: creation of all null decimal array Add DecimalType support in new_null_array May 6, 2022
@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label May 6, 2022
@alamb
Copy link
Contributor

alamb commented May 6, 2022

Thanks @yjshen

@alamb alamb merged commit e0a527b into apache:master May 6, 2022
ovr pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 15, 2022
* minor: creation of all null decimal array

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants