Rename OffsetSize::fn is_large to const OffsetSize::IS_LARGE
#1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <13716567376yh@gmail.com>
github-actions
bot
added
arrow
HaoYang670
changed the title
fn is_large by const IS_LARGEfn is_large with const IS_LARGE
viirya
reviewed
May 6, 2022
Comment on lines
+47
to
+49
| /// Get the data type of the array. | ||
| // Declare this function as `pub const fn` after | ||
| // https://github.com/rust-lang/rust/issues/93706 is merged. |
There was a problem hiding this comment.
Make consistent comment style?
Suggested change
| /// Get the data type of the array. | |
| // Declare this function as `pub const fn` after | |
| // https://github.com/rust-lang/rust/issues/93706 is merged. | |
| // Get the data type of the array. | |
| // Declare this function as `pub const fn` after | |
| // https://github.com/rust-lang/rust/issues/93706 is merged. |
There was a problem hiding this comment.
I just want to make the first line (Get the data type of the array.) be the doc of this function. And it is not necessary to expose the 2nd and 3rd line to users, so I use //.
viirya
approved these changes
May 7, 2022
|
Could we merge this PR, as the potential merge conflict is high? |
|
Merged. Thanks @HaoYang670 |
|
Thank you for your review. @viirya !! |
alamb
changed the title
fn is_large with const IS_LARGEOffsetSize::fn is_large to const OffsetSize::IS_LARGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
Closes #1658 .
What changes are included in this PR?
Replace
fn is_largewithconst IS_LARGE.Unfortunately, we still can't declare
BinaryArray::get_data_typeasconst fn. Please look at the docs.Are there any user-facing changes?
Yes.
fn is_largeis deleted