Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dictionary arrays in length and bit_length #1674

Merged
merged 2 commits into from
May 9, 2022
Merged

Support dictionary arrays in length and bit_length #1674

merged 2 commits into from
May 9, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented May 8, 2022

Which issue does this PR close?

Closes #1672.
Closes #1673.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label May 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022 •
edited
Loading

Codecov Report

Merging #1674 (6d0ab61) into master (22e9f95) will increase coverage by 0.14%.
The diff coverage is 95.31%.

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
+ Coverage   83.02%   83.17%   +0.14%     
==========================================
  Files         193      193              
  Lines       55612    56071     +459     
==========================================
+ Hits        46174    46638     +464     
+ Misses       9438     9433       -5
Impacted Files Coverage Δ
arrow/src/compute/kernels/length.rs 99.04% <95.31%> (-0.96%) ⬇️
arrow/src/array/array.rs 89.67% <0.00%> (-3.04%) ⬇️
parquet/src/arrow/array_reader/test_util.rs 81.08% <0.00%> (-2.26%) ⬇️
arrow/src/ipc/reader.rs 88.80% <0.00%> (-0.23%) ⬇️
arrow/src/compute/kernels/take.rs 95.27% <0.00%> (-0.14%) ⬇️
parquet/src/arrow/array_reader.rs 89.76% <0.00%> (-0.07%) ⬇️
arrow/src/ffi.rs 88.51% <0.00%> (ø)
arrow/src/array/mod.rs 100.00% <0.00%> (ø)
arrow-flight/src/utils.rs 0.00% <0.00%> (ø)
arrow/src/array/builder.rs 86.79% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e9f95...6d0ab61. Read the comment docs.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label May 9, 2022
sunchao
sunchao approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one tiny nit. Thanks @viirya !

arrow/src/compute/kernels/length.rs Outdated
@@ -127,10 +150,26 @@ where
/// For list array, length is the number of elements in each list.
/// For string array and binary array, length is the number of bytes of each value.
///
/// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray and BinaryArray/LargeBinaryArray
/// * this only accepts ListArray/LargeListArray, StringArray/LargeStringArray andBinaryArray/LargeBinaryArray,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space after and

@viirya
Copy link
Member Author

viirya commented May 9, 2022

Thank you @sunchao !

@viirya viirya merged commit 42c9e02 into apache:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunchao sunchao sunchao approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add DictionaryArray support for bit_length kernel Add DictionaryArray support for length kernel
3 participants
@viirya @codecov-commenter @sunchao