Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null_count from ArrayData::try_new() #1721

Merged
merged 1 commit into from May 22, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

Closes #911.

Rationale for this change

Avoid the inconsistency of between ArrayData::null_count and ArrayData::null_nit_buffer.

(Sadly, we could not do any simplification in ArrayData::validate.)

Are there any user-facing changes?

The API of ArrayData::try_new()

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label May 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1721 (c2b5431) into master (7b164a0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1721      +/-   ##
==========================================
- Coverage   83.32%   83.30%   -0.02%     
==========================================
  Files         195      195              
  Lines       56044    55978      -66     
==========================================
- Hits        46698    46635      -63     
+ Misses       9346     9343       -3     
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 86.85% <ø> (+0.05%) ⬆️
arrow/src/compute/util.rs 98.90% <ø> (-0.01%) ⬇️
arrow/src/array/data.rs 83.65% <100.00%> (-0.80%) ⬇️
parquet/src/encodings/encoding.rs 93.65% <0.00%> (+0.19%) ⬆️
arrow/src/datatypes/datatype.rs 65.79% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b164a0...c2b5431. Read the comment docs.

@tustvold tustvold added the api-change Changes to the arrow API label May 22, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you 👍

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @HaoYang670

@viirya viirya merged commit 4de6895 into apache:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove null_count from ArrayData::try_new()
4 participants