Fix schema comparison for non_canonical_map when running flight test #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
May 23, 2022
| @@ -215,7 +215,7 @@ async fn consume_flight_location( | |||
| flight_data_to_arrow_batch(&data, actual_schema.clone(), &dictionaries_by_id) | |||
| .expect("Unable to convert flight data to Arrow batch"); | |||
|
|
|||
| assert_eq!(expected_batch.schema(), actual_batch.schema()); | |||
| assert_eq!(actual_schema, actual_batch.schema()); | |||
There was a problem hiding this comment.
expected_batch's schema is uploaded one. The flight server could make cosmetic change (e.g., from non canonical map to canonical one) to the schema.
actual_schema is received from flight. We should take it.
tustvold
approved these changes
May 23, 2022
|
Thanks @tustvold. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1730.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?