Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin nightly version to bypass packed_simd build error #1743

Merged
merged 1 commit into from
May 24, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented May 24, 2022

Which issue does this PR close?

Closes #1734.

Rationale for this change

There is building error on packed_simd with latest nightly. Before packed_simd publishes new release, our CI will be blocked by the errors. This is to unblock PRs.

What changes are included in this PR?

Are there any user-facing changes?

@viirya
Copy link
Member Author

viirya commented May 24, 2022

cc @sunchao

@viirya
Copy link
Member Author

viirya commented May 24, 2022

We can change back to latest nightly once packed_simd publishes new release with a fix. This is for unblocking PRs.

@codecov-commenter
Copy link

Codecov Report

Merging #1743 (ee51fcc) into master (a14a1d3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1743   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         196      196           
  Lines       55961    55961           
=======================================
+ Hits        46624    46626    +2     
+ Misses       9337     9335    -2     
Impacted Files Coverage Δ
arrow/src/array/transform/mod.rs 86.85% <0.00%> (+0.11%) ⬆️
arrow/src/datatypes/datatype.rs 65.79% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14a1d3...ee51fcc. Read the comment docs.

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @viirya !

@viirya
Copy link
Member Author

viirya commented May 24, 2022

Merging for unblocking other PRs. Thanks @sunchao

@viirya viirya merged commit 5cf06bf into apache:master May 24, 2022
viirya added a commit to viirya/arrow-rs that referenced this pull request Jun 1, 2022
tustvold pushed a commit that referenced this pull request Jun 1, 2022
@alamb alamb added the development-process Related to development process of arrow-rs label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest nightly fails to build with feature simd
4 participants