Rename string_concat to concat_elements_utf8
#1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HaoYang670 @tustvold and @viirya |
tustvold
approved these changes
May 26, 2022
|
lgtm |
|
LGTM. A new compute kernel was born! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #1747
Rationale for this change
Per suggestion from @tustvold here #1752 (comment)
The idea is to have a naming scheme that is consistent with other kernels such as
eq_utf8It also allows us to add a consistently named
concat_elements_dynto work with dynamic array types,which I will track in a momenttracked in #1752What changes are included in this PR?
Rename
string_concattoconcat_elements_utf8Are there any user-facing changes?
No, code is not yet released