Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary size combine option bitmap #1781

Merged

Conversation

ismailmaj
Copy link
Contributor

Which issue does this PR close?

Closes #1780.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 3, 2022
@ismailmaj
Copy link
Contributor Author

Still need to add tests for buffers with offsets.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #1781 (a455fbb) into master (1a64677) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1781   +/-   ##
=======================================
  Coverage   83.39%   83.40%           
=======================================
  Files         198      198           
  Lines       56142    56222   +80     
=======================================
+ Hits        46822    46890   +68     
- Misses       9320     9332   +12     
Impacted Files Coverage Δ
arrow/src/compute/kernels/arithmetic.rs 90.86% <ø> (ø)
arrow/src/compute/kernels/comparison.rs 92.45% <ø> (ø)
arrow/src/compute/kernels/boolean.rs 96.79% <100.00%> (ø)
arrow/src/compute/kernels/concat_elements.rs 100.00% <100.00%> (ø)
arrow/src/compute/util.rs 98.99% <100.00%> (+0.09%) ⬆️
parquet/src/util/cursor.rs 62.18% <0.00%> (-1.69%) ⬇️
parquet/src/file/serialized_reader.rs 94.46% <0.00%> (-1.17%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/ipc/reader.rs 90.73% <0.00%> (-0.11%) ⬇️
parquet/src/file/writer.rs 92.84% <0.00%> (-0.02%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a64677...a455fbb. Read the comment docs.

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor nits, very nice 👍. I think this has a bug, however, but the fix should be very simple and easy to test

arrow/src/compute/util.rs Outdated Show resolved Hide resolved
arrow/src/compute/util.rs Outdated Show resolved Hide resolved
arrow/src/compute/util.rs Outdated Show resolved Hide resolved
arrow/src/compute/util.rs Outdated Show resolved Hide resolved
arrow/src/compute/util.rs Show resolved Hide resolved
arrow/src/compute/util.rs Outdated Show resolved Hide resolved
arrow/src/compute/util.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leave some comments.

arrow/src/compute/util.rs Outdated Show resolved Hide resolved
arrow/src/compute/util.rs Outdated Show resolved Hide resolved
arrow/src/compute/util.rs Outdated Show resolved Hide resolved
@ismailmaj
Copy link
Contributor Author

thanks! @HaoYang670

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will merge once CI finishes. Thanks again 👍

Copy link
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @Ismail-Maj !!

@tustvold tustvold merged commit 25d5452 into apache:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

combine_option_bitmap should accept arbitrary number of input arrays.
4 participants