Write validity buffer for UnionArray in V4 IPC message #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
=======================================
Coverage 83.39% 83.40%
=======================================
Files 198 198
Lines 56205 56244 +39
=======================================
+ Hits 46872 46909 +37
- Misses 9333 9335 +2
Continue to review full report at Codecov.
|
tustvold
approved these changes
Jun 6, 2022
|
|
||
| { | ||
| let file = File::open(&file_name).unwrap(); | ||
| let reader = FileReader::try_new(file, None).unwrap(); |
There was a problem hiding this comment.
Not sure how hard this would be to test, but perhaps we should test what null mask is actually written (I think the reader simply ignores it)
There was a problem hiding this comment.
Yea, the reader just ignores it like C++ reader does. So I skip null mask test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1793.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?