Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list equal for empty offset list array #1818

Merged
merged 2 commits into from Jun 9, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jun 7, 2022

Which issue does this PR close?

Closes #1817.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 7, 2022
arrow/src/array/equal/list.rs Outdated Show resolved Hide resolved
arrow/src/array/equal/list.rs Show resolved Hide resolved
arrow/src/array/equal/mod.rs Show resolved Hide resolved
@HaoYang670
Copy link
Contributor

I guess this PR is related to #1620.

@codecov-commenter
Copy link

Codecov Report

Merging #1818 (fbead0d) into master (b5fbd11) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1818      +/-   ##
==========================================
- Coverage   83.46%   83.45%   -0.02%     
==========================================
  Files         199      199              
  Lines       56600    56673      +73     
==========================================
+ Hits        47244    47294      +50     
- Misses       9356     9379      +23     
Impacted Files Coverage Δ
arrow/src/array/equal/list.rs 96.47% <100.00%> (+0.08%) ⬆️
arrow/src/array/equal/mod.rs 96.20% <100.00%> (+0.10%) ⬆️
parquet/src/util/memory.rs 87.17% <0.00%> (-2.30%) ⬇️
arrow/src/datatypes/native.rs 66.66% <0.00%> (ø)
parquet/src/arrow/async_reader.rs 0.00% <0.00%> (ø)
arrow/src/array/data.rs 84.16% <0.00%> (+0.18%) ⬆️
arrow/src/datatypes/datatype.rs 65.79% <0.00%> (+0.37%) ⬆️
parquet/src/compression.rs 89.68% <0.00%> (+1.08%) ⬆️
parquet/src/file/footer.rs 98.11% <0.00%> (+2.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5fbd11...fbead0d. Read the comment docs.

@viirya viirya merged commit c92943c into apache:master Jun 9, 2022
@viirya
Copy link
Member Author

viirya commented Jun 9, 2022

Thanks @tustvold @HaoYang670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List equality method should work on empty offset ListArray
4 participants