Add ScalarBuffer abstraction (#1811) #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
reviewed
Jun 8, 2022
| /// All [`ArrowNativeType`] are valid for all possible backing byte representations, and as | ||
| /// a result they are "trivially safely transmutable". | ||
| #[derive(Debug)] | ||
| pub struct ScalarBuffer<T: ArrowNativeType> { |
There was a problem hiding this comment.
Is this to be public to users? If this is only for used internally in Array implementations.
There was a problem hiding this comment.
We definitely could make it crate local, I think a ScalarMutableBuffer would be of great interest to parquet, and so I was just thinking we'd provide public safe APIs for interacting with buffers. Don't feel strongly
viirya
approved these changes
Jun 8, 2022
alamb
reviewed
Jun 9, 2022
| use crate::datatypes::ArrowNativeType; | ||
| use std::ops::Deref; | ||
|
|
||
| /// Provides a safe API for interpreting a [`Buffer`] as a slice of [`ArrowNativeType`] |
There was a problem hiding this comment.
Am I right in understanding that the key use of this API will be to check the validity of buffer once and subsequently "just access" it rather than having to do the checks subsequently (or skip them entirely)?
There was a problem hiding this comment.
Precisely - see #1825 for how this works in practice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1811
Rationale for this change
This would allow replacing RawPtrBox with a safe abstraction
What changes are included in this PR?
This adds a new owning
ScalarBufferabstraction that wraps aBufferin an owning abstractionAre there any user-facing changes?
No