Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Clarify PageIterator Documentation #1831

Merged
merged 1 commit into from Jun 10, 2022

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

If i'm right, PageIterator should return one column in multi row group.
I was mislead by this 馃槀 when i first time read this.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jun 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1831 (e8d6db5) into master (db41b33) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1831   +/-   ##
=======================================
  Coverage   83.53%   83.54%           
=======================================
  Files         200      200           
  Lines       56798    56798           
=======================================
+ Hits        47449    47451    +2     
+ Misses       9349     9347    -2     
Impacted Files Coverage 螖
parquet/src/column/page.rs 98.68% <酶> (酶)
parquet/src/encodings/encoding.rs 93.46% <0.00%> (-0.20%) 猬囷笍
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.68%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update db41b33...e8d6db5. Read the comment docs.

@tustvold
Copy link
Contributor

tustvold commented Jun 10, 2022

I agree the many levels of readers and iterators are deeply confusing 馃槄 I do hope to clean it up at some point, but the record level APIs make this non-trivial

@tustvold tustvold changed the title [Minor] Fix annotation [Minor] Clarify PageIterator Documentation Jun 10, 2022
@tustvold tustvold merged commit 23acd55 into apache:master Jun 10, 2022
@alamb alamb changed the title [Minor] Clarify PageIterator Documentation [Minor] Clarify PageIterator Documentation Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants