Expose BitSliceIterator and BitIndexIterator (#1864)
#1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
public-fast-bit-iteration
branch
from
6126646
to
4af7ae1
Compare
tustvold
commented
Jun 13, 2022
Comment on lines
+118
to
+119
| let next = self.iter.next().expect("IndexIterator exhausted early"); | ||
| self.remaining -= 1; |
There was a problem hiding this comment.
Fascinatingly swapping these two lines around results in a 50% performance regression for some benchmarks
Codecov Report
@@ Coverage Diff @@
## master #1865 +/- ##
==========================================
- Coverage 83.48% 83.45% -0.03%
==========================================
Files 201 203 +2
Lines 57000 57145 +145
==========================================
+ Hits 47584 47688 +104
- Misses 9416 9457 +41
Continue to review full report at Codecov.
|
alamb
reviewed
Jun 15, 2022
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
changed the title
BitSliceIterator and BitIndexIterator (#1864)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1864
Rationale for this change
We have heavily optimised code for iterating bitmasks, we should use it in more places
What changes are included in this PR?
Extracts the core logic of filter::SlicesIterator and filter::IndexIterator into a public module where they can be used by other code.
I have confirmed there is no impact on the performance of the filter benchmarks
Are there any user-facing changes?
No