Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow cast from other datatypes to NullType #1942

Merged
merged 1 commit into from Jun 28, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #1923

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 24, 2022
@liukun4515
Copy link
Contributor Author

@alamb Does this may break some usages in the datafusion or influxio? I have not checked it.

@liukun4515
Copy link
Contributor Author

@nevi-me @viirya PTAL

@alamb
Copy link
Contributor

alamb commented Jun 24, 2022

@alamb Does this may break some usages in the datafusion or influxio? I have not checked it.

I will check

@alamb
Copy link
Contributor

alamb commented Jun 24, 2022

It appears there are some failures in DataFusion with this change 🤔 -- see apache/arrow-datafusion#2787

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks again to @viirya for sorting this out downstream in datafusion: apache/arrow-datafusion#2794

@liukun4515 liukun4515 merged commit 9746e59 into apache:master Jun 28, 2022
17 checks passed
@liukun4515 liukun4515 deleted the remove_cast_othertype_to_null branch June 28, 2022 03:56
@alamb alamb added the api-change Changes to the arrow API label Jul 7, 2022
@alamb alamb changed the title Disallow cast from other datatypes to NullType Disallow cast from other datatypes to NullType Jul 7, 2022
ovr pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow cast from other datatypes to NullType
3 participants