Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parquet test_common feature flags #2003

merged 1 commit into from Jul 8, 2022


Copy link

@tustvold tustvold commented Jul 5, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

Without this running

cargo check -p parquet --features test_common

Would result in

error[E0433]: failed to resolve: could not find `test_util` in `util`
  --> parquet/src/util/test_common/
23 |         PathBuf::from_str(&arrow::util::test_util::parquet_test_data()).unwrap();
   |                                         ^^^^^^^^^ could not find `test_util` in `util`

What changes are included in this PR?

Enables the arrow/test_util feature if the parquet test_common feature is enabled

Are there any user-facing changes?


@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 5, 2022
Copy link

Codecov Report

Merging #2003 (2eadea4) into master (c757829) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2003   +/-   ##
  Coverage   83.58%   83.58%           
  Files         222      222           
  Lines       57522    57522           
+ Hits        48078    48079    +1     
+ Misses       9444     9443    -1     
Impacted Files Coverage Δ
parquet_derive/src/ 65.98% <0.00%> (ø)
parquet/src/encodings/ 93.62% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c757829...2eadea4. Read the comment docs.

@tustvold tustvold mentioned this pull request Jul 5, 2022
@alamb alamb merged commit 58848c4 into apache:master Jul 8, 2022
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
parquet Changes to the parquet crate
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants