Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return reference from UnionArray::child (#2035) #2099

merged 1 commit into from Jul 18, 2022


Copy link

Which issue does this PR close?

Closes #2035

Rationale for this change

See #2035

What changes are included in this PR?

Changes UnionArray::child to return a reference

Are there any user-facing changes?


@tustvold tustvold added the api-change Changes to the arrow API label Jul 18, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 18, 2022
Copy link

Codecov Report

Merging #2099 (28af32c) into master (a6379fe) will increase coverage by 0.02%.
The diff coverage is 88.21%.

❗ Current head 28af32c differs from pull request most recent head ceb6b73. Consider uploading reports for the commit ceb6b73 to get more accurate results

@@            Coverage Diff             @@
##           master    #2099      +/-   ##
+ Coverage   83.70%   83.73%   +0.02%     
  Files         224      225       +1     
  Lines       58967    59362     +395     
+ Hits        49360    49704     +344     
- Misses       9607     9658      +51     
Impacted Files Coverage Δ
arrow/src/array/ 90.59% <ø> (ø)
parquet/src/arrow/record_reader/ 89.17% <ø> (ø)
parquet/src/ 91.49% <ø> (ø)
parquet/src/column/ 62.00% <ø> (ø)
parquet/src/column/reader/ 63.38% <0.00%> (-5.86%) ⬇️
parquet/src/file/ 91.49% <78.57%> (-1.07%) ⬇️
parquet/src/ 74.25% <80.35%> (-0.51%) ⬇️
parquet/src/encodings/ 88.70% <85.79%> (-0.84%) ⬇️
parquet/src/column/writer/ 88.46% <88.46%> (ø)
arrow/src/array/builder/ 83.03% <90.90%> (-2.34%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6379fe...ceb6b73. Read the comment docs.

@tustvold tustvold merged commit 619be77 into apache:master Jul 18, 2022
17 checks passed
Copy link

ursabot commented Jul 18, 2022

Benchmark runs are scheduled for baseline = 6a37d9f and contender = 619be77. 619be77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb changed the title Return reference from UnionArray::child (#2035) Return reference from UnionArray::child (#2035) Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api-change Changes to the arrow API arrow Changes to the arrow crate
None yet

Successfully merging this pull request may close these issues.

Return reference from UnionArray::child
5 participants