Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run integration tests when arrow changes #2152

Merged
merged 1 commit into from Jul 23, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 23, 2022

Which issue does this PR close?

re #2149

Rationale for this change

These actions test the integration of the arrow crate, yet they run on all PRs (including parquet changes and now also object_store changes) and they take significant time (32 minutes), often the longest test in the suite

What changes are included in this PR?

  1. Only run this integration if files in arrow or .github change
  2. Rename test to be more specific

Are there any user-facing changes?

no

Testing:

@alamb alamb changed the title Only run integration tests when arrow changes Only run integration tests when arrow changes Jul 23, 2022

jobs:

integration:
name: Integration Test
name: Archery test With other arrows
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed this to be more specific

@alamb alamb marked this pull request as ready for review July 23, 2022 21:33
@alamb
Copy link
Contributor Author

alamb commented Jul 23, 2022

cc @viirya and @tustvold

@codecov-commenter
Copy link

Codecov Report

Merging #2152 (9235baf) into master (19a7189) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2152   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files         237      237           
  Lines       61296    61296           
=======================================
+ Hits        50792    50793    +1     
+ Misses      10504    10503    -1     
Impacted Files Coverage Δ
...row/src/array/builder/string_dictionary_builder.rs 90.64% <0.00%> (-0.72%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/datatype.rs 63.00% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@viirya viirya merged commit 7746e7d into apache:master Jul 23, 2022
@ursabot
Copy link

ursabot commented Jul 23, 2022

Benchmark runs are scheduled for baseline = aa5c849 and contender = 7746e7d. 7746e7d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants