Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prost and tonic related crates #2268

Merged
merged 11 commits into from
Aug 2, 2022
Merged

Update prost and tonic related crates #2268

merged 11 commits into from
Aug 2, 2022

Conversation

carols10cents
Copy link
Contributor

These all need to be updated together.

dependabot bot and others added 10 commits August 1, 2022 13:43
@dependabot
Update prost requirement from 0.10 to 0.11
6e4f570 
Updates the requirements on [prost](https://github.com/tokio-rs/prost) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/prost/releases)
- [Commits](tokio-rs/prost@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: prost
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Update tonic-build requirement from 0.7 to 0.8
9a2b6f1 
Updates the requirements on [tonic-build](https://github.com/hyperium/tonic) to permit the latest version.
- [Release notes](https://github.com/hyperium/tonic/releases)
- [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md)
- [Commits](hyperium/tonic@v0.7.0...v0.8.0)

---
updated-dependencies:
- dependency-name: tonic-build
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Update tonic requirement from 0.7 to 0.8
6319d65 
Updates the requirements on [tonic](https://github.com/hyperium/tonic) to permit the latest version.
- [Release notes](https://github.com/hyperium/tonic/releases)
- [Changelog](https://github.com/hyperium/tonic/blob/master/CHANGELOG.md)
- [Commits](hyperium/tonic@v0.7.0...v0.8.0)

---
updated-dependencies:
- dependency-name: tonic
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Update prost-derive requirement from 0.10 to 0.11
dc19a68 
Updates the requirements on [prost-derive](https://github.com/tokio-rs/prost) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/prost/releases)
- [Commits](tokio-rs/prost@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: prost-derive
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Update prost-types requirement from 0.10.0 to 0.11.0
3b542ed 
Updates the requirements on [prost-types](https://github.com/tokio-rs/prost) to permit the latest version.
- [Release notes](https://github.com/tokio-rs/prost/releases)
- [Commits](tokio-rs/prost@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: prost-types
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@carols10cents
Merge remote-tracking branch 'upstream/dependabot/cargo/master/prost-…
2c6f77b 
…derive-0.11' into update-prost-tonic
@carols10cents
Merge remote-tracking branch 'upstream/dependabot/cargo/master/prost-…
a29e690 
…types-0.11.0' into update-prost-tonic
@carols10cents
Merge remote-tracking branch 'upstream/dependabot/cargo/master/tonic-…
0c0fda7 
…0.8' into update-prost-tonic
@carols10cents
Merge remote-tracking branch 'upstream/dependabot/cargo/master/tonic-…
53589e7 
…build-0.8' into update-prost-tonic
@carols10cents
Update vendored tonic/prost generated code
5653512
@github-actions github-actions bot added the arrow-flight Changes to the arrow-flight crate label Aug 1, 2022
@carols10cents
Copy link
Contributor Author

Hm so the Windows and macos builds are failing because prost-build no longer bundles protoc, and nothing is installing protoc. But the prost generated files are checked in to source control? So could we tell the build script not to try to build those if protoc isn't available?

@carols10cents
Copy link
Contributor Author

🤷🏻‍♀️ orrrrr we can sidestep that and install protoc.

@tustvold
Copy link
Contributor

tustvold commented Aug 1, 2022

Thank you for dealing with this ❤️

@tustvold tustvold merged commit cd45ecb into apache:master Aug 2, 2022
@ursabot
Copy link

ursabot commented Aug 2, 2022

Benchmark runs are scheduled for baseline = b4fa47d and contender = cd45ecb. cd45ecb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Aug 2, 2022
Closed
@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carols10cents @tustvold @ursabot @Dandandan @alamb