Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Improve types shown in cast error messages #2295

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 3, 2022

Which issue does this PR close?

N/A

Rationale for this change

As suggested by @viirya on #2284 (comment) the amount of qualification on the types in cast error messages is both not helpful it may actually obscure the actual problem

What changes are included in this PR?

Use standard fmt::Debug printing for type names in error messages, as done in the rest of the file

Are there any user-facing changes?

Instead of looking like

Cast error: Cannot cast ... to value of arrow::datatypes::types::Time32SecondType type

Errors now look like

Cast error: Cannot cast ... to value of Time32 type

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2295 (68954b8) into master (299908e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
- Coverage   82.14%   82.14%   -0.01%     
==========================================
  Files         248      248              
  Lines       63492    63493       +1     
==========================================
- Hits        52158    52156       -2     
- Misses      11334    11337       +3     
Impacted Files Coverage Δ
arrow/src/compute/kernels/cast.rs 97.17% <100.00%> (+<0.01%) ⬆️
arrow/src/datatypes/datatype.rs 62.30% <0.00%> (-0.32%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
parquet/src/arrow/schema.rs 96.76% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tustvold tustvold merged commit 22185fd into apache:master Aug 3, 2022
@ursabot
Copy link

ursabot commented Aug 3, 2022

Benchmark runs are scheduled for baseline = 1cc8563 and contender = 22185fd. 22185fd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants