Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IPC writer should truncate string array with all empty string #2314

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

JasonLi-cn
Copy link
Contributor

Which issue does this PR close?

Closes #2312 (comment)

Rationale for this change

fixed ipc truncation bug

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 4, 2022
arrow/src/ipc/writer.rs Outdated Show resolved Hide resolved
@JasonLi-cn
Copy link
Contributor Author

@viirya please review

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it cause a failure?

// actual
assert_eq!(serialize(&record_batch).len(), serialize(&record_batch_slice).len());

It just doesn't truncate the record batch, right?

arrow/src/ipc/writer.rs Outdated Show resolved Hide resolved
@viirya viirya changed the title fix: IPC truncation failure fix: IPC writer should truncate string array with all empty string Aug 4, 2022
@JasonLi-cn
Copy link
Contributor Author

"It just doesn't truncate the record batch, right?" @viirya
yes

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Thanks for fixing it.

@JasonLi-cn
Copy link
Contributor Author

It’s my pleasure @viirya

arrow/src/ipc/writer.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #2314 (bd9ad05) into master (e835853) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2314      +/-   ##
==========================================
- Coverage   81.26%   81.25%   -0.01%     
==========================================
  Files         248      248              
  Lines       60605    60623      +18     
==========================================
+ Hits        49249    49258       +9     
- Misses      11356    11365       +9     
Impacted Files Coverage Δ
arrow/src/ipc/writer.rs 84.92% <100.00%> (-0.54%) ⬇️
...row/src/array/builder/string_dictionary_builder.rs 90.64% <0.00%> (-0.72%) ⬇️
arrow/src/datatypes/datatype.rs 62.30% <0.00%> (-0.32%) ⬇️
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
parquet/src/arrow/schema.rs 96.93% <0.00%> (+0.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@viirya viirya merged commit d56d88e into apache:master Aug 4, 2022
@ursabot
Copy link

ursabot commented Aug 4, 2022

Benchmark runs are scheduled for baseline = e835853 and contender = d56d88e. d56d88e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPC writer should truncate string array with all empty string
5 participants