refactor: Make read_num_bytes a function instead of a macro #2364
Conversation
Reduces duplication of this code (now it is just once per type)
|
Have you run the benchmarks to confirm this doesn't adversely impact performance? LLVM tends to be pretty pessimistic about const inlining, and this can then prevent it eliminating bounds checks |
|
Benchmark +/- are just noise on my laptop best I can tell 🤷 Which is what I would expect as best I can tell, all the places where this is called, the size of |
|
Benchmark runs are scheduled for baseline = 80a6ef7 and contender = 56f7904. 56f7904 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
Reduces duplication of this code (now it is just once per type, instead of once per macro invocation). Generally macros should not be used when a plain function will do.