Implement AsyncFileReader for Box<dyn AsyncFileReader>
#2368
Conversation
| @@ -136,6 +136,23 @@ pub trait AsyncFileReader: Send { | |||
| fn get_metadata(&mut self) -> BoxFuture<'_, Result<Arc<ParquetMetaData>>>; | |||
| } | |||
|
|
|||
| impl AsyncFileReader for Box<dyn AsyncFileReader> { | |||
There was a problem hiding this comment.
its unfortunate we can't imp this for everything that provides AsRef<AsyncFileReader> (and whatever send/sync magic is necessary)
There was a problem hiding this comment.
If there is a way, I'm not aware of it. In this specific case the requirement for mutable access means realistically Box is the only probable container
|
Benchmark runs are scheduled for baseline = d4ad4b7 and contender = 53dd5aa. 53dd5aa is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Follow up to #2366, this not only will avoid a regression in the future, but also provides useful functionality apache/datafusion#3051 (comment)