Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in page skipping #2504

merged 1 commit into from Aug 18, 2022


Copy link

Which issue does this PR close?

Closes #2503

Rationale for this change

Small bug in the page skipping logic. If we try and skip a page which has already been peeked, we were not updating the remaining bytes which would eventually lead to a panic when we overran the end of the chunk.

What changes are included in this PR?

Update the remaining bytes and tweak the unit test so it fails if this issue regresses

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 18, 2022
@tustvold tustvold merged commit 526a2b8 into apache:master Aug 18, 2022
12 checks passed
Copy link

ursabot commented Aug 18, 2022

Benchmark runs are scheduled for baseline = c34f07f and contender = 526a2b8. 526a2b8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Copy link

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thinkharderdev 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
parquet Changes to the parquet crate
None yet

Successfully merging this pull request may close these issues.

Panic in SerializedPageReader without offset index
4 participants